fix: use Restrict() to avoid REFER permission denial#49
Open
charles-cooper wants to merge 1 commit intoZouuup:mainfrom
Open
fix: use Restrict() to avoid REFER permission denial#49charles-cooper wants to merge 1 commit intoZouuup:mainfrom
charles-cooper wants to merge 1 commit intoZouuup:mainfrom
Conversation
Using separate RestrictPaths() and RestrictNet() calls creates two Landlock rulesets. go-landlock's RestrictNet() clears handledAccessFS, and since REFER is "always denied by default when not in handled_access_fs" (per kernel docs), the second ruleset implicitly denies REFER. This caused cross-directory rename/link operations to fail with EXDEV even when the directory was specified with --rw. Fix by using Restrict() with combined rules, which creates a single ruleset with both FS and network rules, preserving REFER permission. Fixes Zouuup#48 Generated-by: pi + Claude claude-opus-4-20250514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using separate
RestrictPaths()andRestrictNet()calls creates two Landlock rulesets. go-landlock'sRestrictNet()clearshandledAccessFS, and since REFER is "always denied by default when not in handled_access_fs" (per kernel docs), the second ruleset implicitly denies REFER.This caused cross-directory rename/link operations to fail with EXDEV even when the directory was specified with
--rw.Fix by using
Restrict()with combined rules, which creates a single ruleset with both FS and network rules, preserving REFER permission.Fixes #48
Generated by pi + Claude claude-opus-4-5