Added support for MPS on apple silicon devices for faster inference.#38
Open
JunkyByte wants to merge 3 commits intoZrrSkywalker:mainfrom
Open
Added support for MPS on apple silicon devices for faster inference.#38JunkyByte wants to merge 3 commits intoZrrSkywalker:mainfrom
JunkyByte wants to merge 3 commits intoZrrSkywalker:mainfrom
Conversation
Author
|
Other changes you see are just autopep8 style corrections that were applied by default by my editor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for your work, I have modified your code to support device switching with
--deviceflag.I changed the code to move tensors to correct device accordingly.
These changes also fix a bug in the current version: When using
vit_tcpu can be used for model inference but other tensors are still loaded on gpu causing an error if torch is not compiled with cuda making cpu inference not possible.As SAM works out of the box with MPS on apple silicon devices I choose the default device to be cuda or mps when available fallbacking to cpu otherwise.
I tested MPS on M2 Macbook air with
torch==2.0.1installed.I changed the README to mirror these changes, let me know if you are interested in a merge. Thanks!