ci(react): Add basic catalog integration tests.#1625
Open
ditman wants to merge 5 commits into
Open
Conversation
7 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ditman
force-pushed
the
react-add-integration-tests
branch
from
d845bba to
d34360e
Compare
Collaborator
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces deep cloning of messages using structuredClone in App.tsx to prevent unintended mutations, refactors the test utility whenSettled to avoid nested act blocks, and adds a comprehensive suite of tests for various UI examples under tests/v0_9/. The review feedback highlights several opportunities to improve code safety in the new test files by replacing the non-null assertion operator (!) with optional chaining (?.) on lookup results that may fail.
Collaborator
Author
|
OK, this should be ready for @josemontespg to take a look! |
ditman
changed the title
ditman
force-pushed
the
react-add-integration-tests
branch
from
1a8aa0a to
749bb77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the remaining integration tests to the React adapter.
There are some minor changes to the react integration testing harness to improve the interaction with elements that require some more than a "click".
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.