empty PR to verify web_ci build-and-test no longer hangs (#1637)#1641
Closed
polina-c wants to merge 2 commits into
Closed
empty PR to verify web_ci build-and-test no longer hangs (#1637)#1641polina-c wants to merge 2 commits into
polina-c wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates a comment in tools/composer/src/test/setup.ts to reference issue #1637, clarifying why the anchor prototype override is needed to prevent vitest run from hanging. There are no review comments, so I have no feedback to provide.
polina-c
changed the title
…revent test:all hang The `yarn dev:react` / `yarn dev:lit` webServer commands spawn vite as a grandchild that Playwright's teardown fails to kill, leaving orphaned dev servers so `playwright test` never exits and the consolidated `yarn test:all` hangs until the job timeout. Run vite directly so Playwright can terminate the servers cleanly. Refs #1637. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #1637