Skip to content

feat(angular): export MarkdownRenderer in public API of v0.8#1658

Merged
josemontespg merged 1 commit into
a2ui-project:mainfrom
josemontespg:export-markdown-renderer
Jun 15, 2026
Merged

feat(angular): export MarkdownRenderer in public API of v0.8#1658
josemontespg merged 1 commit into
a2ui-project:mainfrom
josemontespg:export-markdown-renderer

Conversation

@josemontespg

@josemontespg josemontespg commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Export the MarkdownRenderer symbol in the public api file for angular v0.8 and v0.9. This improves 1P compatibility when dependents import MarkdownRenderer directly.

No changes to v0.9, because it already exports MarkdownRenderer

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the exports in renderers/angular/src/v0_8/data/index.ts to include MarkdownRenderer. The feedback suggests removing the spaces inside the curly braces of the export statement to maintain formatting consistency with the rest of the codebase.

Comment thread renderers/angular/src/v0_8/data/index.ts Outdated
@josemontespg josemontespg requested a review from ditman June 15, 2026 21:44
@josemontespg josemontespg changed the title feat(angular): export MarkdownRenderer in public API of v0.8 and v0.9 feat(angular): export MarkdownRenderer in public API of v0.8 Jun 15, 2026
@josemontespg josemontespg enabled auto-merge (squash) June 15, 2026 21:45
@josemontespg josemontespg force-pushed the export-markdown-renderer branch from be413aa to 994d538 Compare June 15, 2026 21:56
@ditman

ditman commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

v0.9 is exporting MarkdownRenderer from here:

export * from './core/markdown';

(It's harder to see because it's an export *)

@ditman ditman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an update to the CHANGELOG because it'll affect the published API of the package

@josemontespg josemontespg merged commit b8e87b0 into a2ui-project:main Jun 15, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in A2UI Jun 15, 2026
@josemontespg

Copy link
Copy Markdown
Collaborator Author

Agent: Create a PR to add this to the appropriate CHANGELOG file

josemontespg added a commit that referenced this pull request Jun 16, 2026
Adds the changelog entry for PR #1658 under Unreleased.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants