FIX: groupBy breaking under certain conditions#153
Open
adwaith-implementhit wants to merge 3 commits intoa8m:masterfrom
Open
FIX: groupBy breaking under certain conditions#153adwaith-implementhit wants to merge 3 commits intoa8m:masterfrom
adwaith-implementhit wants to merge 3 commits intoa8m:masterfrom
Conversation
Stronger type checking
Stronger type checking.
Stronger type checking. If the value of prop is something like "valueOf", or "watch", then by the previous logic, the elm wouldn't be grouped at all, since reult[prop] would be a function, and wouldn't have the property "push".
This was referenced Oct 8, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "groupBy" function can be asked to group by property names such as "valueOf", or other properties implicitly defined in the empty object.
Without this check, a new array isn't created (since the value of the property is a function, not null), and when time comes to push the element into the array, the code will throw an error, saying that result.push is undefined.
The other two (countBy, repeat) are just for readabilty