allow replacing null keys with specified value in groupBy filter#41
Open
AlexCuse wants to merge 1 commit intoa8m:masterfrom
Open
allow replacing null keys with specified value in groupBy filter#41AlexCuse wants to merge 1 commit intoa8m:masterfrom
AlexCuse wants to merge 1 commit intoa8m:masterfrom
Conversation
…eys) don't replace false keys
Owner
|
@AlexCuse Thx for the PR. $scope.players = [
{ name: 'Gene', team: 'alpha' },
{ name: 'George', team: 'beta' },
{ name: 'Steve', team: 'gamma' },
{ name: 'Paula', team: 'beta' },
{ name: 'Scruath',team: 'gamma' },
{ name: 'Dan' },
{ name: 'Alex' }
];
$scope.fallback = { team: 'others' }; <ul ng-repeat="(key, value) in players | defaults:fallback | groupBy: 'team'" >
Group name: {{ key }}
<li ng-repeat="player in value">
player: {{ player.name }}
</li>
</ul>let me know what do you think... |
Author
|
I didn't see the defaults filter, does seem like that would work. Here is a plunker using defaults: http://plnkr.co/edit/rEDbqLkQ4ZaZ9z2Dlmro?p=info And another using the null replacement syntax I added: http://plnkr.co/edit/RYc3RriigIJYgHF9vGlJ As long as the defaults can be inlined like that (so I can tell why I am doing something special with the default value later on) I think defaults would be fine, if a bit less concise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I gave up on trying to figure out why, but the combination of groupBy, toArray and angular's built-in orderBy filter had some disastrous side effects for me. So added an option to replace null/undefined keys as a means to control where missing keys fall in the natural ordering.
It seems to build OK and the tests pass, I just didn't check the combined files in because a "reverseArray" function that I didn't touch is showing as removed in angular-filter.js.