fix: resolve_display_name handles multi-hyphen tags#10
Merged
aannoo merged 1 commit intoaannoo:mainfrom Mar 14, 2026
Merged
Conversation
split_once('-') only tried the first hyphen, failing for tags like
"vc-p0-p1-parallel-vani". Now iterates all split points so compound
tags resolve correctly.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_display_nameusedsplit_once('-')to separate tag from suffix, which only tried the first hyphen. For tags likevc-p0-p1-parallel, the lookup failed because it searched for tagvc+ suffixp0-p1-parallel-vaniinstead of iterating all split points.Now iterates all hyphen positions so compound tags resolve correctly.
What changed
src/instances.rs: replacedsplit_once('-')with a loop over all split points, trying each(tag, suffix)combination until a match is found.test_resolve_display_name_multi_hyphen.Test plan
cargo test resolve_display— new test covers multi-hyphen tagshcom listcorrectly resolvesvc-p0-p1-parallel-vanito its display nameResubmitted from #8 — cleaned up to contain only this fix.
🤖 Generated with Claude Code