feat: add current date to route database filename#49
Open
Warchlik wants to merge 1 commit into
Open
Conversation
Owner
|
Hi @Warchlik, thank you a lot for your contribution, solving my latest issue 🙇 I'd be happy to include it, but I first have some minor remarks and review comments I'd kindly ask you to have a look at. Thank you very much! |
aardjon
reviewed
Apr 24, 2026
| """ | ||
|
|
||
| _DB_FILE_NAME: Final = "routedb_v1.sqlite" | ||
| _DB_FILE_NAME: Final = f"routedb_v1-{datetime.datetime.now(tz=datetime.UTC).date().today().strftime('%Y-%m-%d')}.sqlite" |
Owner
There was a problem hiding this comment.
What is the .date().today() part needed for? Doesn't datetime.datetime.now(tz=datetime.UTC).strftime('%Y-%m-%d') just do it, or am I missing something?
If it is not necessary, please remove it (also at the similar line in the test file).
aardjon
reviewed
May 8, 2026
Owner
There was a problem hiding this comment.
I don't think the .python_version file should be added to the repository, so please remove it from your change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the route database filename from
routedb_v1.sqliteto
routedb_v1-YYYY-MM-DD.sqliteby appending the current date.Changes:
_DB_FILE_NAMEindb_v1/__init__.pyto include current dateDB_FILE_NAMEto module level in testsRelated issue:
Closes #48
Verify:
pytest test/integration/test_filter_dbcreation.py -v