🎨 Palette: Use X icon for close action in Command Palette#120
🎨 Palette: Use X icon for close action in Command Palette#120
Conversation
Replaced the left-pointing chevron (ChevronRight with a rotate-180 class) with a standard X icon from lucide-react for the "Close command palette" button in FramerDashboardLayout. This makes the interface more intuitive, as X universally implies a close action, whereas a left-pointing chevron typically implies navigating "back". Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Updates `MAX_ACCEPTABLE_MAPE` in `scripts/run-forecast-backtests.ts` to correctly read from `process.env.FORECAST_MAX_ACCEPTABLE_MAPE` with a default of 50. Also runs `pnpm format` to resolve Prettier code style issues across 32 files that caused the `Lint & Type Check` workflow to fail. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Replaced the left-pointing chevron (ChevronRight with a rotate-180 class) with a standard X icon from lucide-react for the "Close command palette" button in FramerDashboardLayout. This makes the interface more intuitive, as X universally implies a close action, whereas a left-pointing chevron typically implies navigating "back". Also fixes a CI failure in check-models by properly defaulting MAX_ACCEPTABLE_MAPE from FORECAST_MAX_ACCEPTABLE_MAPE. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Replaced the left-pointing chevron (ChevronRight with a rotate-180 class) with a standard X icon from lucide-react for the "Close command palette" button in FramerDashboardLayout. This makes the interface more intuitive, as X universally implies a close action, whereas a left-pointing chevron typically implies navigating "back". Also fixes CI failures: - check-models: properly reads MAX_ACCEPTABLE_MAPE from FORECAST_MAX_ACCEPTABLE_MAPE with a default instead of being hardcoded. - Lint & Type Check: ran global pnpm format to resolve pre-existing styling issues across the repository (in a separate isolated commit for clear history). Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
1 participant
💡 What: The UX enhancement added: Changed the "Close command palette" icon from a rotated left-pointing chevron to a standard
Xicon.🎯 Why: The user problem it solves: Users universally recognize an "X" as a close action for modals and palettes, whereas a left-pointing chevron typically implies a "back" navigation action. This micro-ux improvement makes the interaction more intuitive.
♿ Accessibility: The
aria-label="Close command palette"remained intact, maintaining proper screen reader support.PR created automatically by Jules for task 4494770730240053117 started by @aarjava