Skip to content

🎨 Palette: Add aria-pressed to filter pill toggles#134

Open
aarjava wants to merge 4 commits intomainfrom
palette/add-aria-pressed-16057699622848575654
Open

🎨 Palette: Add aria-pressed to filter pill toggles#134
aarjava wants to merge 4 commits intomainfrom
palette/add-aria-pressed-16057699622848575654

Conversation

@aarjava
Copy link
Copy Markdown
Owner

@aarjava aarjava commented Mar 25, 2026

💡 What: Added the aria-pressed attribute to the FilterPills component's toggle buttons.
🎯 Why: Elements functioning as standalone toggle buttons must use the aria-pressed attribute to correctly indicate their toggled state to screen readers. This improves accessibility by communicating when an option is selected or active.
📸 Before/After: Visuals remain unchanged. A new test tests/filter-pills.spec.tsx and manual verification through Playwright confirm the correct attribute is present on the <button> element.
♿ Accessibility: Ensures correct toggle button state semantics are exposed to screen readers.


PR created automatically by Jules for task 16057699622848575654 started by @aarjava

Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fluxlens-ai Ready Ready Preview, Comment Mar 25, 2026 11:25pm

Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant