Refactor demo apps: improve naming conventions and code structure#589
Merged
oblomov-dev merged 6 commits intostandardfrom Mar 15, 2026
Merged
Refactor demo apps: improve naming conventions and code structure#589oblomov-dev merged 6 commits intostandardfrom
oblomov-dev merged 6 commits intostandardfrom
Conversation
- Remove CREATE PUBLIC from all class definitions - App 355: extract on_init and view_display, add client attribute to PROTECTED SECTION - App 357: remove iv_/io_ prefixes from add_cell parameters - App 358: rename ty_product -> ty_s_product, mt_products -> t_products; remove blank line between TYPES and DATA - App 359: remove mv_ prefix from attributes, lv_ from locals; convert && concatenation to string templates - App 360: remove mv_ prefix from attributes, lv_ from locals; convert && concatenation to string templates - Fix blank lines in all methods (start/end, before IF, 2 lines between methods) https://claude.ai/code/session_01GwFbxdvWVuf3iKjN5VhHrb
Align p directly under n in all ->_() and ->__() method calls where p appears on the continuation line. Also fix VALUE #( tuple continuation indentation to match. https://claude.ai/code/session_01GwFbxdvWVuf3iKjN5VhHrb
- Add blank line before view_display() in on_init methods to separate data initialisation from display logic - Break method chains after each ->__() call so each chained call starts on its own line (e.g. root->__(`Shell`) on one line, )->__( n = `Page` ...) on the next) https://claude.ai/code/session_01GwFbxdvWVuf3iKjN5VhHrb
- PRIVATE SECTION must always be empty; use PROTECTED SECTION at most - Setup methods (on_init): blank line between last assignment and first non-assignment statement (e.g. before view_display()) - z2ui5_cl_util_xml chaining: each ->_() / ->__() call on its own line - z2ui5_cl_util_xml p alignment: p must align directly under n - VALUE #() formatting: all fields inline or each on its own line, no mix https://claude.ai/code/session_01GwFbxdvWVuf3iKjN5VhHrb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors multiple demo application classes to improve code quality, readability, and consistency. The changes focus on standardizing naming conventions, simplifying string concatenation syntax, and improving code organization.
Key Changes
Naming Convention Updates:
mv_prefix from instance variable names across demo apps 359, 360 (e.g.,mv_price→price,mv_first_name→first_name)lv_prefix from local variable names (e.g.,lv_float_bind→float_bind,lv_concat→concat)iv_prefix from method parameters in demo app 357 (e.g.,io_row→row,iv_icon→icon)ty_producttoty_s_productfor consistencymt_productstot_productsCode Structure Improvements:
CREATE PUBLICclause from class definitions (changed toDEFINITION PUBLIConly)on_init()andview_display()methodsclientreference assignment to the beginning ofmain()method in demo app 355String Concatenation Modernization:
|...|syntax in demo apps 359 and 360Code Organization:
Notable Implementation Details
https://claude.ai/code/session_01GwFbxdvWVuf3iKjN5VhHrb