Merged
Conversation
abdebek
approved these changes
Jan 23, 2026
Owner
abdebek
left a comment
There was a problem hiding this comment.
Good job, @erwinkramer! Thank you!
Contributor
Author
|
@abdebek thanks for merging. I see the latest releases are all based of the same (old) commit, did u notice? |
Owner
|
@erwinkramer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the OAuth middleware, focusing on clearer token validation logic, more robust challenge responses, and improved test coverage. It also updates package dependencies and adds sample configuration for token validation.
Closes #16
OAuth middleware improvements:
McpOAuthAuthenticationMiddlewareto clarify the authentication flow, including improved handling of token validation, challenge scope calculation, and more modular helper methods such asBuildChallengeScopesandTryGetBearerToken. This results in more maintainable and readable code. [1] [2] [3] [4] [5] [6] [7] [8] [9]Testing enhancements:
OAuthChallengeTokenValidationTeststo verify that a 401 Unauthorized challenge is correctly returned when token validation is enabled and no token is provided.Sample and configuration updates:
DemoServiceExtensions.cs) to enable JWT validation and audience validation in the demo configuration.Dependency updates:
MCPify.Sample.csproj, includingMicrosoft.AspNetCore.Authentication.JwtBearer,Microsoft.AspNetCore.OpenApi,Microsoft.IdentityModel.Protocols.OpenIdConnect,Microsoft.EntityFrameworkCore.InMemory, andSwashbuckle.AspNetCore.