ci: Simplify validation gates#18
Closed
abdufelsayed wants to merge 4 commits into
Closed
Conversation
Run the source distribution check as part of Required CI across pull requests, main, release branches, tag pushes, and manual dispatch. Retry opam install commands so transient source archive fetch failures do not fail the gate before Awskit checks run. Co-Authored-By: Codex <noreply@openai.com>
Remove the source distribution job from GitHub Actions so Required CI stays focused on package metadata, package matrices, docs/examples, no-network evidence, and MinIO evidence. Keep scripts/check.sh source-distribution documented as a release-time local check for building and inspecting the source archive. Co-Authored-By: Codex <noreply@openai.com>
abdufelsayed
changed the title
Replace the check.sh policy wrapper with direct opam and Dune commands in CI and release documentation. Keep scripts/test.sh as the reported test runner for no-service, local-service, and stress test runs. Rename Dune aliases and CI titles so they describe the tests or build targets they run. Co-Authored-By: Codex <noreply@openai.com>
abdufelsayed
changed the title
Configure the opam archive mirror before dependency installs so CI does not depend on every upstream source host being reachable during matrix runs. The failed PR jobs died while fetching ptime, astring, and rresult archives before any dune package command ran. Co-Authored-By: Codex <noreply@openai.com>
Owner
Author
|
Replaced by #19 after renaming the head branch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify Awskit's validation gates so CI shows the actual commands and test lanes instead of routing repository policy through shell wrappers.
Required CI now has explicit lanes for repository hygiene, no-service correctness tests, documentation/example builds, local-service S3 integration tests, and per-package opam install/build/test matrices. Source distribution checks stay out of required CI and are documented as direct release-time
dune-releasecommands.This removes
scripts/check.shandscripts/release-env.sh.scripts/test.shremains as the reported test runner where it adds useful behavior: durable logs, local MinIO lifecycle management, and captured test output for no-service, local-service, and stress test runs.The Dune aliases and CI labels were renamed to describe what they run:
@correctness,@integration,@stress,@s3-local-service,@s3-simulator,@s3-transfer-faults,@s3-domain-laws,@s3-protocol-laws, and@runtime-http-contracts.A follow-up CI reliability fix configures the opam archive cache before dependency installs. The failed matrix jobs were dying while fetching upstream
ptime,astring, andrresultarchives, before any Dune package build or test command ran.Validated locally with the pre-commit hook, including formatting, build, and test checks. Also checked workflow YAML parsing, shell syntax for
scripts/test.sh, Dune rule resolution for the renamed aliases, and the opam archive-mirror command in a fresh opam root.