ci: Run stress gates in required CI#20
Merged
Merged
Conversation
Constrain the protocol object-key generator to produce keys accepted by the domain type. Endpoint and presign properties construct Object_key.t values directly, so generated keys must respect the same relative-segment validation as production inputs. Add protocol family coverage for generated object keys so future generator changes keep this surface visible. Co-Authored-By: Codex <noreply@openai.com>
Replace the separate no-service correctness job with the reported stress gate so required CI exercises the higher-pressure no-service path directly. Run local-service integration with the expensive profile as its required service-backed stress gate and keep the manual stress workflow dispatch-only for ad hoc reruns or raised counts. Co-Authored-By: Codex <noreply@openai.com>
abdufelsayed
changed the title
Name the non-Eio package matrix after the Lwt package family so required CI uses parallel Lwt and Eio check titles instead of a vague default lane. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constrain the S3 protocol object-key generator so endpoint and presign properties only receive keys accepted by Object_key.t. The main CI failure hit a generated key with a relative segment sequence that the domain validator correctly rejects, while the protocol properties were constructing Object_key.t with of_string_exn.
This also makes the required CI gate match the kind of evidence that caught the issue. The no-service required job now runs the reported @stress path with AWSKIT_QCHECK_COUNT=2000 instead of a separate quick correctness lane, and the S3 local-service required job runs integration with AWSKIT_INTEGRATION_PROFILE=expensive. The package matrices now use parallel Lwt and Eio check names instead of a vague default package lane. The manual stress workflow remains available for ad hoc reruns or raised no-service counts, but no longer has a weekly schedule.
Add the object-key generator to protocol family coverage and register a property that generated protocol object keys validate. This keeps future generator changes visible in the protocol workload instead of relying on endpoint properties to trip over invalid inputs.
Found while investigating the main CI failure in https://github.com/abdufelsayed/awskit/actions/runs/28291883504/job/83825159159.
Validated locally with the failing QCheck seed on the focused protocol alias and @correctness before this CI cleanup; the cleanup commits also passed pre-commit fmt, build, and test hooks plus workflow YAML parsing and git diff whitespace checks.