Skip to content

⚡ Bolt: Pre-compile regex for validation functions #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abhimehro wants to merge 1 commit into from
Closed

⚡ Bolt: Pre-compile regex for validation functions #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,7 @@
## 2026-01-27 - Redundant Validation for Cached Data
**Learning:** Re-validating resource properties (like DNS/IP) when using *cached content* is pure overhead. If the content is served from memory (proven safe at fetch time), checking the *current* state of the source is disconnected from the data being used.
**Action:** When using a multi-stage pipeline (Warmup -> Process), ensure validation state persists alongside the data cache. Avoid clearing validation caches between stages if the data cache is not also cleared.

## 2025-02-24 - [Regex Compilation for Repeated Validation]

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when references to undefined definitions are found. Note

[no-undefined-references] Found reference to undefined definition

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when shortcut reference links are used. Note

[no-shortcut-reference-link] Use the trailing [] on reference links
**Learning:** Pre-compiling regexes for functions called in tight loops (like `is_valid_rule` which runs on 10k+ items) yields a >2x performance improvement (0.0525s -> 0.0229s).
**Action:** Always pre-compile regexes used in validation loops.
Comment on lines 39 to +45
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new journal entry is dated 2025-02-24 but is appended after a 2026-01-27 entry, which makes the journal timeline non-chronological. Either reorder the sections by date or adjust the date so entries remain in consistent chronological order.

Suggested change
## 2026-01-27 - Redundant Validation for Cached Data
**Learning:** Re-validating resource properties (like DNS/IP) when using *cached content* is pure overhead. If the content is served from memory (proven safe at fetch time), checking the *current* state of the source is disconnected from the data being used.
**Action:** When using a multi-stage pipeline (Warmup -> Process), ensure validation state persists alongside the data cache. Avoid clearing validation caches between stages if the data cache is not also cleared.
## 2025-02-24 - [Regex Compilation for Repeated Validation]
**Learning:** Pre-compiling regexes for functions called in tight loops (like `is_valid_rule` which runs on 10k+ items) yields a >2x performance improvement (0.0525s -> 0.0229s).
**Action:** Always pre-compile regexes used in validation loops.
## 2025-02-24 - [Regex Compilation for Repeated Validation]
**Learning:** Pre-compiling regexes for functions called in tight loops (like `is_valid_rule` which runs on 10k+ items) yields a >2x performance improvement (0.0525s -> 0.0229s).
**Action:** Always pre-compile regexes used in validation loops.
## 2026-01-27 - Redundant Validation for Cached Data
**Learning:** Re-validating resource properties (like DNS/IP) when using *cached content* is pure overhead. If the content is served from memory (proven safe at fetch time), checking the *current* state of the source is disconnected from the data being used.
**Action:** When using a multi-stage pipeline (Warmup -> Process), ensure validation state persists alongside the data cache. Avoid clearing validation caches between stages if the data cache is not also cleared.

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion .python-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.13
3.13
13 changes: 10 additions & 3 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,8 +397,12 @@ def extract_profile_id(text: str) -> str:
return text


# Compiled regex for performance
PROFILE_ID_PATTERN = re.compile(r"^[a-zA-Z0-9_-]+$")
Comment on lines +400 to +401
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PROFILE_ID_PATTERN is introduced mid-file even though main.py already has a dedicated "1. Constants" section near the top (e.g., API_BASE, USER_AGENT). Consider moving this compiled regex (and the rule pattern below) into that constants block so module-level configuration stays centralized and easier to discover.

Copilot uses AI. Check for mistakes.


def is_valid_profile_id_format(profile_id: str) -> bool:
if not re.match(r"^[a-zA-Z0-9_-]+$", profile_id):
if not PROFILE_ID_PATTERN.match(profile_id):
return False
if len(profile_id) > 64:
return False
Comment on lines 404 to 408
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validate_profile_id() still uses an inline re.match(r"^[a-zA-Z0-9_-]+$", profile_id) when logging errors, duplicating the regex now captured by PROFILE_ID_PATTERN. Reuse PROFILE_ID_PATTERN there as well so the pattern stays consistent and only needs to be updated in one place.

Copilot uses AI. Check for mistakes.
Expand All @@ -416,6 +420,10 @@ def validate_profile_id(profile_id: str, log_errors: bool = True) -> bool:
return True


# Compiled regex for performance (called in tight loops)
RULE_PATTERN = re.compile(r"^[a-zA-Z0-9.\-_:*\/]+$")


def is_valid_rule(rule: str) -> bool:
"""
Validates that a rule is safe to use.
Expand All @@ -426,8 +434,7 @@ def is_valid_rule(rule: str) -> bool:
return False

# Strict whitelist to prevent injection
# ^[a-zA-Z0-9.\-_:*\/]+$
if not re.match(r"^[a-zA-Z0-9.\-_:*\/]+$", rule):
if not RULE_PATTERN.match(rule):
return False

return True
Expand Down
Loading