Skip to content

chore: fix ruff violations F841, F811, E741 in main.py #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

chore: fix ruff violations F841, F811, E741 in main.py #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38340db
Initial plan
Copilot Feb 20, 2026
303e598
Initial plan
Copilot Feb 20, 2026
02f9e87
Fix ruff code quality issues: F841, F811, E741 in main.py
Copilot Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 1 addition & 42 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,7 +1454,7 @@

_cache_stats["misses"] += 1

except httpx.HTTPStatusError as e:
except httpx.HTTPStatusError:

Check notice

Code scanning / Pylintpython3 (reported by Codacy)

The except handler raises immediately Note

The except handler raises immediately

Check warning

Code scanning / Prospector (reported by Codacy)

The except handler raises immediately (try-except-raise) Warning

The except handler raises immediately (try-except-raise)
# Re-raise with original exception (don't catch and re-raise)
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is contradictory: it says “don't catch and re-raise”, but the code is explicitly catching HTTPStatusError and re-raising it. Consider rewording to clarify the intent (e.g., that the exception is intentionally propagated unchanged / without wrapping).

Suggested change
# Re-raise with original exception (don't catch and re-raise)
# Intentionally propagate HTTPStatusError unchanged (no wrapping or swallowing)

Copilot uses AI. Check for mistakes.
raise

Expand Down Expand Up @@ -2355,47 +2355,6 @@
# --------------------------------------------------------------------------- #
# 5. Entry-point
# --------------------------------------------------------------------------- #
def print_summary_table(
sync_results: List[Dict[str, Any]], success_count: int, total: int, dry_run: bool
) -> None:
# 1. Setup Data
max_p = max((len(r["profile"]) for r in sync_results), default=25)
w = [max(25, max_p), 10, 12, 10, 15]

t_f, t_r, t_d = sum(r["folders"] for r in sync_results), sum(r["rules"] for r in sync_results), sum(r["duration"] for r in sync_results)
all_ok = success_count == total
t_status = ("✅ Ready" if dry_run else "✅ All Good") if all_ok else "❌ Errors"
t_col = Colors.GREEN if all_ok else Colors.FAIL

# 2. Render
if not USE_COLORS:
# Simple ASCII Fallback
header = f"{'Profile ID':<{w[0]}} | {'Folders':>{w[1]}} | {'Rules':>{w[2]}} | {'Duration':>{w[3]}} | {'Status':<{w[4]}}"
sep = "-" * len(header)
print(f"\n{('DRY RUN' if dry_run else 'SYNC') + ' SUMMARY':^{len(header)}}\n{sep}\n{header}\n{sep}")
for r in sync_results:
print(f"{r['profile']:<{w[0]}} | {r['folders']:>{w[1]}} | {r['rules']:>{w[2]},} | {r['duration']:>{w[3]-1}.1f}s | {r['status_label']:<{w[4]}}")
print(f"{sep}\n{'TOTAL':<{w[0]}} | {t_f:>{w[1]}} | {t_r:>{w[2]},} | {t_d:>{w[3]-1}.1f}s | {t_status:<{w[4]}}\n{sep}\n")
return

# Unicode Table
def line(l, m, r): return f"{Colors.BOLD}{l}{m.join('─' * (x+2) for x in w)}{r}{Colors.ENDC}"
def row(c): return f"{Colors.BOLD}│{Colors.ENDC} {c[0]:<{w[0]}} {Colors.BOLD}│{Colors.ENDC} {c[1]:>{w[1]}} {Colors.BOLD}│{Colors.ENDC} {c[2]:>{w[2]}} {Colors.BOLD}│{Colors.ENDC} {c[3]:>{w[3]}} {Colors.BOLD}│{Colors.ENDC} {c[4]:<{w[4]}} {Colors.BOLD}│{Colors.ENDC}"

print(f"\n{line('┌', '─', '┐')}")
title = f"{'DRY RUN' if dry_run else 'SYNC'} SUMMARY"
print(f"{Colors.BOLD}│{Colors.CYAN if dry_run else Colors.HEADER}{title:^{sum(w) + 14}}{Colors.ENDC}{Colors.BOLD}│{Colors.ENDC}")
print(f"{line('├', '┬', '┤')}\n{row([f'{Colors.HEADER}Profile ID{Colors.ENDC}', f'{Colors.HEADER}Folders{Colors.ENDC}', f'{Colors.HEADER}Rules{Colors.ENDC}', f'{Colors.HEADER}Duration{Colors.ENDC}', f'{Colors.HEADER}Status{Colors.ENDC}'])}")
print(line("├", "┼", "┤"))

for r in sync_results:
sc = Colors.GREEN if r["success"] else Colors.FAIL
print(row([r["profile"], str(r["folders"]), f"{r['rules']:,}", f"{r['duration']:.1f}s", f"{sc}{r['status_label']}{Colors.ENDC}"]))

print(f"{line('├', '┼', '┤')}\n{row(['TOTAL', str(t_f), f'{t_r:,}', f'{t_d:.1f}s', f'{t_col}{t_status}{Colors.ENDC}'])}")
print(f"{line('└', '┴', '┘')}\n")


def parse_args() -> argparse.Namespace:
"""
Parses command-line arguments for the Control D sync tool.
Expand Down
24 changes: 24 additions & 0 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading