Skip to content

update browsersync to fix npm vulnerabilities#25

Open
jegli wants to merge 1 commit into
abmaonline:masterfrom
jegli:master
Open

update browsersync to fix npm vulnerabilities#25
jegli wants to merge 1 commit into
abmaonline:masterfrom
jegli:master

Conversation

@jegli

@jegli jegli commented Aug 12, 2020

Copy link
Copy Markdown
Contributor

Hi @abmaonline

Browsersync finally updated its dependencies which resolves the npm vulnerabilities. I have updated the dependency in my fork, built aemfed and used the version in our project. It works just like before. Feel free to test on your end as well.

Thanks again and have a nice evening.

@abmaonline

Copy link
Copy Markdown
Owner

Thanks! Since it needs node 8 now, I was already working on a local branch to upgrade all relevant packages to node 8. Good to now it is working fine on your project, since testing the Browsersync update would be most of the work (since aemfed is essentially an extension for it :P)!

I will try to finish the upgrade in the coming days and create a release candidate for it. Would be great if you could test that one for a while as well?

@jegli

jegli commented Aug 13, 2020

Copy link
Copy Markdown
Contributor Author

Oh, good point regarding node 8. 😅

I will be happy to test the new rc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants