update browsersync to fix npm vulnerabilities#25
Open
jegli wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks! Since it needs node 8 now, I was already working on a local branch to upgrade all relevant packages to node 8. Good to now it is working fine on your project, since testing the Browsersync update would be most of the work (since aemfed is essentially an extension for it :P)! I will try to finish the upgrade in the coming days and create a release candidate for it. Would be great if you could test that one for a while as well? |
Contributor
Author
|
Oh, good point regarding node 8. 😅 I will be happy to test the new rc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @abmaonline
Browsersync finally updated its dependencies which resolves the npm vulnerabilities. I have updated the dependency in my fork, built aemfed and used the version in our project. It works just like before. Feel free to test on your end as well.
Thanks again and have a nice evening.