Skip to content

Use "call-interactively" when executing a command in a window#238

Open
BonfaceKilz wants to merge 1 commit into
abo-abo:masterfrom
BonfaceKilz:master
Open

Use "call-interactively" when executing a command in a window#238
BonfaceKilz wants to merge 1 commit into
abo-abo:masterfrom
BonfaceKilz:master

Conversation

@BonfaceKilz

Copy link
Copy Markdown

This PR makes "aw-execute-command-other-window" work for all commands.

Currently, we use funcall; and this fails for some commands and as an example:

ELISP> (funcall 'find-file)
*** Eval error ***  Wrong number of arguments: #[(ad--addoit-function filename &optional wildcards) "\306�\307 �\310\216\311\312
\"\211�\205�\0\313\314
\"\205�\0\315\313\314
\"!��\203)\0\313\316
\"\202*\0
�
��\"�\203<\0eb\210Sy\210-�)\207" [ad-return-value save-match-data-internal filename matched line-number ad--addoit-function nil match-data #[nil "\301�\302\"\207" [save-match-data-internal set-match-data evaporate] 3] string-match "^\\(.*\\):\\([0-9]+\\):?$" match-string 2 string-to-number 1 wildcards] 5], 1

And this is fixed by:

(call-interactively 'find-file)

This should fix this issue

* ace-window.el (aw-execute-command-other-window): Replace funcall
with call-interactively.
@Thaodan

Thaodan commented Feb 28, 2026

Copy link
Copy Markdown

This PR would be much easier to merge if you create a topic/patch branch.

Magit's wiki explains quite well why:
https://github.com/magit/magit/wiki/Dedicated-pull-request-branches

@BonfaceKilz

BonfaceKilz commented Mar 2, 2026 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants