Use "call-interactively" when executing a command in a window#238
Open
BonfaceKilz wants to merge 1 commit into
Open
Use "call-interactively" when executing a command in a window#238BonfaceKilz wants to merge 1 commit into
BonfaceKilz wants to merge 1 commit into
Conversation
* ace-window.el (aw-execute-command-other-window): Replace funcall with call-interactively.
|
This PR would be much easier to merge if you create a topic/patch branch. Magit's wiki explains quite well why: |
Author
|
Björn Kettunen ***@***.***>
aliandika:
Thaodan left a comment (abo-abo/ace-window#238)
This PR would be much easier to merge if you create a topic/patch branch.
Heya. This is from some 4 years ago! I'll have
a look tomorrow and update what needs to be
updated should it be still relevant.
Regardless, thanks for looking at this!
[...]
…--
(Life is like a pencil that will surely run out,
but will leave the beautiful writing of life)
(Unless a solution defies the laws of physics,
it is solvable)
(D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
(hkp://keys.openpgp.org))
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes "aw-execute-command-other-window" work for all commands.
Currently, we use funcall; and this fails for some commands and as an example:
And this is fixed by:
This should fix this issue