Skip to content

Remove unnecessary cl-case quotes#248

Open
dsedivec wants to merge 1 commit into
abo-abo:masterfrom
dsedivec:patch-1
Open

Remove unnecessary cl-case quotes#248
dsedivec wants to merge 1 commit into
abo-abo:masterfrom
dsedivec:patch-1

Conversation

@dsedivec

@dsedivec dsedivec commented Sep 2, 2024

Copy link
Copy Markdown

Emacs master is now warning when you incorrectly include quotes in cl-case forms. Loading ace-window currently yields:

ace-window.el: Warning: Case 'visible will match ‘quote’.  If that’s intended, write (visible quote) instead.  Otherwise, don’t quote ‘visible’.
ace-window.el: Warning: Case 'global will match ‘quote’.  If that’s intended, write (global quote) instead.  Otherwise, don’t quote ‘global’.
ace-window.el: Warning: Case 'frame will match ‘quote’.  If that’s intended, write (frame quote) instead.  Otherwise, don’t quote ‘frame’.

I believe this PR will fix those errors.

Thank you for all your software, including ace-window. :)

@rennsax

rennsax commented Sep 6, 2024

Copy link
Copy Markdown

+1 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants