ace-window.el (aw-make-frame): Fix height using cdr of aw-frame-size#255
Open
skalawag wants to merge 1 commit into
Open
ace-window.el (aw-make-frame): Fix height using cdr of aw-frame-size#255skalawag wants to merge 1 commit into
skalawag wants to merge 1 commit into
Conversation
The height parameter was incorrectly using (car aw-frame-size), the width component, instead of (cdr aw-frame-size). This caused any explicit height value to be silently ignored, with the width value used in its place. Also correct the aw-frame-size docstring: the units are characters and text lines (as documented by make-frame), not pixels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The height parameter was incorrectly using (car aw-frame-size), the
width component, instead of (cdr aw-frame-size). This caused any
explicit height value to be silently ignored, with the width value
used in its place.
Also correct the aw-frame-size docstring: the units are characters
and text lines (as documented by make-frame), not pixels.
Reproduction:
#+begin_src emacs-lisp
;; Set a frame size where width and height are visibly different.
(setq aw-frame-size '(120 . 40))
#+end_src
Then, with at least two windows visible, invoke
ace-windowand pressz(or whichever characteraw-make-frame-charis bound to). A newframe will appear. Inspect its dimensions:
#+begin_src emacs-lisp
(cons (frame-width) (frame-height)) ; run in the new frame
#+end_src
Expected:
(120 . 40)--- width 120 columns, height 40 lines.Actual:
(120 . 120)--- both dimensions are the width value because(car aw-frame-size)(120) is used for height instead of(cdr aw-frame-size)(40).