Serve JS libs with static templatetag instead of hardcoded url#38
Open
pierreben wants to merge 2 commits intoaboutcode-org:mainfrom
Open
Serve JS libs with static templatetag instead of hardcoded url#38pierreben wants to merge 2 commits intoaboutcode-org:mainfrom
pierreben wants to merge 2 commits intoaboutcode-org:mainfrom
Conversation
Signed-off-by: Benjamin PIERRE <contact@benjamin-pierre.dev>
Signed-off-by: Benjamin PIERRE <contact@benjamin-pierre.dev>
2beac3e to
0534377
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a small issue in the default config where the static URLs are currently hardcoded :
To address this, I implemented a lazy static URL loader, which allows the use of Django's
statictemplate tag within this configuration.