Fix validate() to report errors for invalid SPDX expressions with tra…#126
Merged
AyanSinhaMahapatra merged 2 commits intoMay 15, 2026
Conversation
…iling operators The validate() method failed silently when encountering expressions with trailing operators (e.g. 'GPL-3.0-or-later AND'). The root cause was that the exception handler accessed e.token_string on ExpressionError, but only ExpressionParseError (a subclass) has that attribute. Fix by catching ExpressionParseError and ExpressionError separately. Fixes aboutcode-org#114 Signed-off-by: Saquib Saifee <saquibsaifee2@gmail.com>
Contributor
Author
|
Take a look at this @AyanSinhaMahapatra @pombredanne. |
Member
|
Closing this as #127 was merged instead. |
AyanSinhaMahapatra
approved these changes
May 15, 2026
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks @saquibsaifee, I'm actually keeping this, the tests are useful enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The validate() method failed silently when encountering expressions with trailing operators (e.g. 'GPL-3.0-or-later AND'). The root cause was that the exception handler accessed e.token_string on ExpressionError, but only ExpressionParseError (a subclass) has that attribute.
Fix by catching ExpressionParseError and ExpressionError separately.
Fixes #114