Adding checkedText and uncheckedText options for#37
Open
osman-masood wants to merge 2 commits intoabpetkov:masterfrom
Open
Adding checkedText and uncheckedText options for#37osman-masood wants to merge 2 commits intoabpetkov:masterfrom
osman-masood wants to merge 2 commits intoabpetkov:masterfrom
Conversation
…d. otherwise, only uncheckedText should be displayed.
Owner
|
Thank you for your contribution, but I'm not planning to add such functionality yet. Even if i did, I wouldn't merge your code as it is right now. There's a big field for improvement and making this work, look and behave better. If I decide that we need such a functionality though, be sure I'll get in touch with you. I appreciate the effort you've made! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Just wanted to add in options to have text for when the toggle is checked/unchecked, like so: