Fix TOTP form double-submission and add error branch coverage#450
Closed
Copilot wants to merge 1 commit intofix/totp-branch-coveragefrom
Closed
Fix TOTP form double-submission and add error branch coverage#450Copilot wants to merge 1 commit intofix/totp-branch-coveragefrom
Copilot wants to merge 1 commit intofix/totp-branch-coveragefrom
Conversation
4 tasks
Copilot
AI
changed the title
[WIP] Fix TOTP form submit and front-end coverage
Fix TOTP form double-submission and add error branch coverage
Mar 16, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TOTP login form was missing
e.preventDefault()in its submit handler, causing a native GET submission to race with the Inertia POST. ThehandleKeyDownEnter path also calledverifyTotp()directly, which broke when the function signature required aFormEvent.Changes
inertia/pages/session/totp.tsxe.preventDefault()toverifyTotpto stop native form submissionhandleKeyDownto calle.preventDefault()+form.requestSubmit()instead of invokingverifyTotp()directlytests/browser/auth.spec.tspress('Enter')to exercise thehandleKeyDownbranch, raisingtotp.tsxbranch coverage from 33% → above the 50% threshold💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.