fix: include [dev] extras in install-dev to fix pytest-timeout missing#156
Open
fix: include [dev] extras in install-dev to fix pytest-timeout missing#156
Conversation
Replaces the manual, incomplete pip install list with the [dev] extras group so new contributors can run make test immediately after make install-dev. Closes #154 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the developer installation flow to rely on the existing Python package “dev” extras, ensuring make install-dev brings in the full pytest toolchain (including pytest-timeout) so make test works out of the box.
Changes:
- Replace the manual
pip install pytest pytest-asyncio ruffstep with installing.[dev]via extras in the editable install. - Ensure
pytest-timeout(required by the repo’s pytest--timeout=120configuration) is installed duringmake install-dev.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip install pytest pytest-asyncio ruffline inmake install-devwith.[dev]extras group[dev]group inpyproject.tomlalready declares all required test dependencies (pytest-timeout,pytest-xdist,pytest-cov,respx,ruff, etc.)make install-dev && make testwithout hitting the--timeout=120unrecognized argument errorTest plan
make install-devinstallspytest-timeoutvia the[dev]extrasmake testruns without theunrecognized arguments: --timeout=120errorruff check .passes (no changes to Python source)Closes #154
🤖 Generated with Claude Code