Middleware: Don't apply HTML transformations to non-HTML responses#101
Merged
Middleware: Don't apply HTML transformations to non-HTML responses#101
Conversation
fstrr
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression I noticed this week, caused by #95, affecting the search feature.
When I added middleware, I applied it to all responses. This has the effect of mangling non-HTML responses, because the middleware passes the response body through Cheerio. Cheerio's default behavior is to expect a full document, and to wrap the content in
htmlandbodytags if it isn't already.This PR adds a check to leave the response alone if it is not
text/html. It also adds an explicitapplication/jsontype to the/api/searchendpoint, though this is not critical to the fix (it reportedtext/plainbefore).The bug was plainly visible in dev tools, as it resulted in an error in the log about failing to parse JSON.