fix(storage): neuron_state record-id mismatch broke activation persistence#29
Merged
Conversation
…tence add_neuron writes the activation-state record as neuron_state:state_<sid>, but get_neuron_state, update_neuron_state and the delete path addressed neuron_state:<sid> without the state_ prefix. So every get_neuron_state missed and returned None, every update/merge was a silent no-op, and the batch helpers (which delegate to these) cascaded empty. recall -> reinforce read empty states and wrote nothing back, so access_frequency / last_activated / activation_level stayed at 0 and the whole activation -> decay -> tiering -> consolidation loop was dormant. Three reader call sites now address neuron_state:state_<sid>, matching the writer. Re-scoped from #16 to the neuron_state fix only, dropping the unrelated deployment-specific changes that PR also carried. Co-authored-by: Robert Sigmundsson <230784065+RobertSigmundsson@users.noreply.github.com>
acidkill
pushed a commit
that referenced
this pull request
Jun 22, 2026
New MCP tool that finds and explains the shortest path between two entities in the neural graph. Returns step-by-step explanation with synapse types, weights, and supporting fiber evidence. - Bidirectional BFS in get_path() (traverses both edge directions) - ConnectionExplainer engine with candidate matching + evidence hydration - ConnectionHandler MCP mixin (tool #29) - 11 new tests covering path found/not found/evidence/dispatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-scope of #16 down to just the
neuron_staterecord-id fix. The rest of #16 was an integration branch carrying deployment-specific code; the other atomic PRs (#17–#27) are already merged.add_neuronwrites the activation-state record asneuron_state:state_<sid>, butget_neuron_state,update_neuron_stateand the delete path addressedneuron_state:<sid>without thestate_prefix. So everyget_neuron_statemissed and returnedNone, every update/merge was a silent no-op, and the batch helpers (which delegate to these) cascaded empty.recall → reinforceread empty states and wrote nothing back, soaccess_frequency/last_activated/activation_levelstayed at 0 and the whole activation → decay → tiering → consolidation loop was dormant.Fix
Three reader call sites now address
neuron_state:state_<sid>, matching the writer inadd_neuron.Credit
Originally reported and fixed by @RobertSigmundsson in #16; re-scoped here to the
neuron_statechange only (co-authored).Type of Change