Fix #15 (round 2): bind finding-pane visibility to explicit bool#18
Closed
aclinick wants to merge 2 commits into
Closed
Fix #15 (round 2): bind finding-pane visibility to explicit bool#18aclinick wants to merge 2 commits into
aclinick wants to merge 2 commits into
Conversation
…ing Apps - #15: BtnCloseFinding now uses a code-behind Click handler that clears OverviewFindingsList.SelectedItem before nulling SelectedFinding, so the ListView TwoWay binding can't immediately re-push the old selection back into the VM. - #16: NavView_ItemInvoked case 'apps' now exits Compare and Settings modes (matching cases 'compare' and 'settings'), so opening the Apps pane on top of an active Compare view hides the Compare sub-panel. Closes #15, closes #16. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Click handler from the previous commit fired correctly but the pane
still didn't collapse, because the visibility binding
`{x:Bind local:MainPage.NullToCollapsed(ViewModel.SelectedFinding)}`
wasn't re-evaluating reliably after the property cleared.
- New observable bool MainPageViewModel.IsFindingDetailVisible, kept in
sync with SelectedFinding via a partial OnSelectedFindingChanged hook.
- Pane Visibility now binds to BoolToVisibility(IsFindingDetailVisible).
- Close handler also sets IsFindingDetailVisible = false explicitly.
- BtnCloseFinding bumped to 32x32 with bigger glyph for a reliable hit
target.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
|
@copilot resolve the merge conflicts in this pull request |
Owner
Author
|
Reopening on a fresh branch — squash-merge of #17 left this one with a dirty merge state. |
auto-merge was automatically disabled
June 4, 2026 14:22
Pull request was closed
Copilot stopped work on behalf of
aclinick due to an error
June 4, 2026 14:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First fix in #17 fixed the close handler firing but the pane still didn't collapse because the function-binding visibility wasn't re-evaluating. Switches to an explicit
IsFindingDetailVisiblebool kept in sync viaOnSelectedFindingChanged. Manually verified — pane now closes.