Fix #15 (round 2): bind finding-pane visibility to explicit bool#19
Merged
Conversation
The Click handler from the previous commit fired correctly but the pane
still didn't collapse, because the visibility binding
`{x:Bind local:MainPage.NullToCollapsed(ViewModel.SelectedFinding)}`
wasn't re-evaluating reliably after the property cleared.
- New observable bool MainPageViewModel.IsFindingDetailVisible, kept in
sync with SelectedFinding via a partial OnSelectedFindingChanged hook.
- Pane Visibility now binds to BoolToVisibility(IsFindingDetailVisible).
- Close handler also sets IsFindingDetailVisible = false explicitly.
- BtnCloseFinding bumped to 32x32 with bigger glyph for a reliable hit
target.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-1 fix in #17 made the close handler fire reliably, but the pane still didn't collapse because the
NullToCollapsedfunction binding wasn't re-evaluating. This switches to an explicitIsFindingDetailVisiblebool kept in sync viaOnSelectedFindingChanged. Manually verified.