Skip to content

Make third-party JS paths configurable#91

Open
darshan-Jahagirdar wants to merge 1 commit into
acooks:masterfrom
darshan-Jahagirdar:codex/configurable-third-party-js
Open

Make third-party JS paths configurable#91
darshan-Jahagirdar wants to merge 1 commit into
acooks:masterfrom
darshan-Jahagirdar:codex/configurable-third-party-js

Conversation

@darshan-Jahagirdar
Copy link
Copy Markdown

Fixes #42.

This makes the third-party JavaScript asset URLs in the generated HTML configurable at build time while preserving the current bundled defaults.

Changes:

  • adds build configuration variables for jquery, mustache, cbuffer, bootstrap bundle, d3, and pako
  • replaces hard-coded third-party script paths in index.tpl.html with template placeholders
  • substitutes those placeholders during assemble-html

Verification:

  • manually assembled html5-client/output/index.html with the default bundled paths and confirmed all placeholders were replaced
  • manually assembled a custom-path variant using /usr/share/javascript/... style paths
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make location of external js dependencies configurable

1 participant