fix(helm): enable readOnlyRootFilesystem + /tmp emptyDir for executor#59
Open
bart-agent[bot] wants to merge 1 commit into
Open
fix(helm): enable readOnlyRootFilesystem + /tmp emptyDir for executor#59bart-agent[bot] wants to merge 1 commit into
bart-agent[bot] wants to merge 1 commit into
Conversation
Enables readOnlyRootFilesystem: true in the default securityContext and adds a tmpDir emptyDir volume (enabled by default) mounted at /tmp, so uv and other tools that write to /tmp work correctly in hardened pod environments. Relates to CUS-8308, ING-2257. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
skrydal
requested changes
Apr 13, 2026
skrydal
left a comment
Contributor
There was a problem hiding this comment.
This change will effectively break deployments for users who do not use code having the change from other PR: https://github.com/acryldata/datahub-fork/pull/8991/changes
As that one sets the HOME/UV_CACHE_DIR to /tmp/....
This is too high of a risk and moreover we shouldn't be mixing up 2 layers of responsibility (config and execution). Please set default values for HOME and UV_CACHE_DIR in values of the helm chart. The change in the datahub-executor will be rendered not needed then.
rajatoss
added a commit
that referenced
this pull request
Jul 23, 2026
Add an evaluate gate job that inspects the PR diff and skips ticket creation when the only changes are the Chart.yaml version/appVersion lines plus the values.yaml image tag line -- i.e. a pure version bump, which the bump bot already mirrors into Terraform and CloudFormation. Uses diff-content analysis rather than author/title/label heuristics: the bump bot also authors real config changes (e.g. readOnlyRootFilesystem, UV_EXTRA_INDEX_URL), and humans author bumps with inconsistent titles, so only the diff shape reliably separates the two. Any template change, any non-tag values.yaml line, or an unavailable patch fails open and creates the ticket. Verified against real PRs: #86 (bump) -> skip, #67 (channel feature) and #59 (bot-authored real change) -> create. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rajatoss
added a commit
that referenced
this pull request
Jul 23, 2026
* ci: add sync reminder workflow for Terraform and CloudFormation The Helm chart is the primary deployment path for the remote executor and lands new flags first. Terraform (datahub-terraform-modules) and CloudFormation (datahub-cloudformation) must be kept in sync manually. This workflow fires when a PR that touches the datahub-executor-worker chart templates or values.yaml is merged, and: - creates a Linear ticket in the Ingestion Pod (Todo) with a Terraform/ CloudFormation sync checklist and the list of changed chart files, - best-effort assigns it to the PR author by matching their git commit email to a Linear user (falls back to unassigned), - comments on the merged PR linking the ticket and @-mentioning the author. The assignee can mark the ticket Done without steps if no sync is needed. Uses pull_request (not pull_request_target) and skips fork PRs so the LINEAR_API_KEY secret is never exposed to untrusted code. Requires a LINEAR_API_KEY repository secret. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * ci(sync-reminder): file tickets in a project and add Slack fallback - Stamp every sync ticket with the "Remote Executor Deployment Sync" Linear project (led by an Ingestion team member) so outstanding syncs are tracked in one place. - When the PR author can't be auto-assigned in Linear, post a fallback notification to #ingestion-pod via the Acryl Data Notifications bot (chat.postMessage), so an orphan ticket gets noticed. Step no-ops if SLACK_BOT_TOKEN is absent. Requires repo/org secrets LINEAR_API_KEY and SLACK_BOT_TOKEN. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * ci(sync-reminder): skip version-bump-only PRs Add an evaluate gate job that inspects the PR diff and skips ticket creation when the only changes are the Chart.yaml version/appVersion lines plus the values.yaml image tag line -- i.e. a pure version bump, which the bump bot already mirrors into Terraform and CloudFormation. Uses diff-content analysis rather than author/title/label heuristics: the bump bot also authors real config changes (e.g. readOnlyRootFilesystem, UV_EXTRA_INDEX_URL), and humans author bumps with inconsistent titles, so only the diff shape reliably separates the two. Any template change, any non-tag values.yaml line, or an unavailable patch fails open and creates the ticket. Verified against real PRs: #86 (bump) -> skip, #67 (channel feature) and #59 (bot-authored real change) -> create.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readOnlyRootFilesystem: true+runAsNonRoot: true+runAsUser: 1000in the defaultsecurityContext(previously commented-out defaults)tmpDirfeature flag (enabled: trueby default) that mounts a writableemptyDirat/tmp— required so uv's cache dir and other tooling that writes to/tmpcontinue to work under the enforced read-only root FSsecurityContextor overridetmpDir.enabled: falseare unaffectedRelates to CUS-8308, ING-2257.
Test plan
readOnlyRootFilesystem: trueand verify executor starts and runs ingestion without filesystem errors/tmpis writable inside the container (uv cache writes succeed)securityContext: {}override are unaffected🤖 Generated with Claude Code