[DON'T MERGE][FIX] shopfloor_reception: remove _set_lot_from_parse#27
Open
sbejaoui wants to merge 3 commits into16.0-imp-reception-drofrom
Open
[DON'T MERGE][FIX] shopfloor_reception: remove _set_lot_from_parse#27sbejaoui wants to merge 3 commits into16.0-imp-reception-drofrom
sbejaoui wants to merge 3 commits into16.0-imp-reception-drofrom
Conversation
…i attribute barcode As some barcodes structures (like GS1) interpretation possibilities.
_set_lot_from_parse method is redundant in _response_for_set_lot, as the lot is already set by the time this method is called additionally, _response_for_set_lot references an undefined parameter parse_result, which I couldn't find in class definition
Member
This should not be removed! This is part of a refactor with GS1 and multi attribute barcodes |
sbejaoui
changed the title
rousseldenis
force-pushed
the
16.0-imp-reception-dro
branch
2 times, most recently
from
faff164 to
9033104
Compare
rousseldenis
force-pushed
the
16.0-imp-reception-dro
branch
2 times, most recently
from
b0aae30 to
0080a2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_set_lot_from_parse method is redundant in _response_for_set_lot, as the lot is already set by the time this method is called
additionally, _response_for_set_lot references an undefined parameter parse_result, which I couldn't find in class definition
cc: @rousseldenis