Draft
Conversation
WilcoFiers
reviewed
Oct 26, 2023
Member
|
And the visible definition will also have to be edited, because it links to the examples. It should link to the new "rule" instead. |
Collaborator
Author
Yes. Not sure what URL the new "rule" would have, though 😅 |
tbostic32
approved these changes
Feb 1, 2024
carlosapaduarte
approved these changes
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per CG discussion, trying to turn definition's examples into a "rule" to see if we can benefit from the existing machinery to provide these in a testable way to tool implementers.
This is meant as a convenience for tool implementers, not to test any sort of requirements.
We will still need to add a bit of machinery to correctly export these test cases. We want them separated from the actual test cases of actual rules, so that testing them is purely opt-in from implementers.
Closes issue(s):
Need for Call for Review:
This will require a 2 weeks Call for Review (new process)
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve