Conversation
| A video element with an explicitly associated text on the same page that describes the audio in the video but no captions. | ||
|
|
||
| ```html | ||
| <p id="text"> |
There was a problem hiding this comment.
On line 137 there is a problem that this PR didn't create, but I noticed it while reviewing: it says ariadescribedby="text". That's missing a hyphen. It should be: aria-describedby="text"
There was a problem hiding this comment.
corrected. Thanks!
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Dan Tripp <113939352+dan-tripp-siteimprove@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
_rules/video-captions-f51b46.md
Outdated
| ## Expectation | ||
|
|
||
| For each test target, audio information that is not conveyed visually in the video, is available through [captions](https://www.w3.org/TR/WCAG22/#dfn-captions). | ||
| For each test target, [captions](https://www.w3.org/TR/WCAG22/#dfn-captions) are provided. |
There was a problem hiding this comment.
I'm not sure about this. Captions should only be required on videos that have auditory information not conveyed visually. This feels like an overreach. But then if you do need to check for auditory-only information, i'm not sure it's useful to have the captions tested separately.
That's why we wrote this as one rule initially, These don't feel like separate tests to me.
There was a problem hiding this comment.
I've added the qualifier back in.
The intent was to have a rule to check the accuracy of provided captions and another rule to check captions are provided.
|
|
||
| #### Passed Example 3 | ||
|
|
||
| A video element with an associated track element that contains incorrect captions. This rule does not evaluate the captions for accuracy or quality. |
There was a problem hiding this comment.
While this doesn't fail the rule, this fails the SC. Rules format doesn't allow us to have passed examples that fail the conformance requirement. I think we'll need to remove this.
New manual rule for correct captions:
Need for Call for Review:
This will require a 2 weeks Call for Review
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve