Update programmatically-determined-link-context.md#2341
Open
sujisreerama wants to merge 5 commits intodevelopfrom
Open
Update programmatically-determined-link-context.md#2341sujisreerama wants to merge 5 commits intodevelopfrom
sujisreerama wants to merge 5 commits intodevelopfrom
Conversation
Updated the glossary section to remove 'aria-decribedby' and changed the description from 'set of all elements' to 'link's accessible description, combined with the set of all elements'
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WilcoFiers
previously requested changes
Jul 31, 2025
sage-putnam
approved these changes
Aug 14, 2025
kengdoj
reviewed
Aug 14, 2025
kengdoj
previously requested changes
Aug 14, 2025
Collaborator
kengdoj
left a comment
There was a problem hiding this comment.
Add accessible name also
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
sujisreerama
commented
Sep 8, 2025
WilcoFiers
approved these changes
Nov 6, 2025
shunguoy
approved these changes
Nov 6, 2025
carlosapaduarte
approved these changes
Nov 6, 2025
Jym77
approved these changes
Nov 7, 2025
Jym77
requested changes
Nov 7, 2025
Collaborator
Jym77
left a comment
There was a problem hiding this comment.
We should add passed/failed examples of links with accessible description to the "link in context" rule.
I'm also not sure why we start a new PR instead of updating #1845 which is doing pretty much the same thing (adding accessible description), with more (adding examples) 🤔
colabottles
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the glossary section to remove 'aria-decribedby' and changed the description from 'set of all elements' to 'link's accessible description, combined with the set of all elements'
<< Describe the changes >>
Closes issue(s):
b20e66,5effbb,aizyf1,fd3a94) consider thetitleattribute? #1766Need for Call for Review:
This will not require a Call for Review << choose reason(s): editorial changes (including to the applicability, expectation or examples section), changes to assumptions, background, accessibility support, change to website/test code (not rule), other (explain). >>
After creating PR:
When merging a PR: