Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c601679c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try | ||
| { | ||
| // Initialize Lucid.Rtc connection | ||
| InitializeRtcConnection(); |
There was a problem hiding this comment.
StartAsync unconditionally calls InitializeRtcConnection(), so the new WebRtcSettings.TryUseNativeClient switch never changes runtime behavior. In environments where the native/Lucid backend is unavailable, setting TryUseNativeClient = false still goes through native initialization and can fail startup instead of falling back to simulation mode as the setting/documentation imply. Gate this initialization on the setting (or remove the setting) so operators can reliably disable native WebRTC.
Useful? React with 👍 / 👎.
1 participant
No description provided.