This repository was archived by the owner on Oct 13, 2023. It is now read-only.
add workspace and all-targets to recipes#27
Open
koivunej wants to merge 1 commit intoactions-rs:masterfrom
Open
add workspace and all-targets to recipes#27koivunej wants to merge 1 commit intoactions-rs:masterfrom
koivunej wants to merge 1 commit intoactions-rs:masterfrom
Conversation
rationale: if someone just copies and pastes the recipes over, the --workspace and --all-targets should do no harm. The user might not want to have all of their test code ran through clippy, so they might choose to just use --examples --bins --benches for example.
3 tasks
|
I was about to propose the a similar change. Are there any reasons for not merging it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rationale: if someone just copies and pastes the recipes over, the --workspace and --all-targets should do no harm but also will not cause surprises when user adds an subcrate. The user might not want to have all of their test code ran through clippy, so they might choose to just use --examples --bins --benches for example. building and testing the workspace doesn't seem to cause issues in crates without a workspace.
this brings the configuration to more in line with
cargo fmt --all ..., which does work on all of the workspace.I haven't used the auditor one so can't comment if it should have some --workspace switch as well though it's configuration doesn't seem to hint at it.