ENH: Add container deployment endpoint to Deployment Controller#130
ENH: Add container deployment endpoint to Deployment Controller#130
Conversation
|
🚀 Automated Build Started - ROCKY9 |
|
✅ Automated Build Completed Successfully - ROCKY9
📂 Results Location (S3DF): $AD_BUILD_SCRATCH/adbuild/BuildSystem/yektay-container/ROCKY9/69ab6c7c123f0544be9a3d18 |
| # Container deployment secrets are loaded per-app from environment variables. | ||
| # Naming convention: CONTAINER_{APP_KEY}_{SECRET} | ||
| # where APP_KEY = component_name uppercased with hyphens replaced by underscores | ||
| def get_container_secrets(component_name: str) -> dict: |
There was a problem hiding this comment.
I see, if we went with this, then we would need to add your app's secrets to the deployment controller environment. Which is doable, but i think it might be better to store the app's secrets on your repo with github secrets. And then just pass in the secrets as arguments? This way if there are other app's that use this workflow, they don't need to store their secrets on the deployment controller either, the secrets can just live on the repo.
There was a problem hiding this comment.
I have implemented your change recommendation. the secrets should be passed through now and live on the projects repo
|
🚀 Automated Build Started - ROCKY9 |
|
✅ Automated Build Completed Successfully - ROCKY9
📂 Results Location (S3DF): $AD_BUILD_SCRATCH/adbuild/BuildSystem/yektay-container/ROCKY9/69af2e62123f0544be9a3df0 |
|
🚀 Automated Build Started - ROCKY9 |
|
✅ Automated Build Completed Successfully - ROCKY9
📂 Results Location (S3DF): $AD_BUILD_SCRATCH/adbuild/BuildSystem/yektay-container/ROCKY9/69af336f123f0544be9a3ec8 |
|
🚀 Automated Build Started - ROCKY9 |
|
✅ Automated Build Completed Successfully - ROCKY9
📂 Results Location (S3DF): $AD_BUILD_SCRATCH/adbuild/BuildSystem/yektay-container/ROCKY9/69b439a2e1677654d72d6937 |
…loyment controller
YektaY
force-pushed
the
yektay/container
branch
from
e20820c to
ef321e8
Compare
|
🚀 Automated Build Started - ROCKY9 |
|
✅ Automated Build Completed Successfully - ROCKY9
📂 Results Location (S3DF): $AD_BUILD_SCRATCH/adbuild/BuildSystem/yektay-container/ROCKY9/69b43d8ce1677654d72d6a11 |
|
🚀 Automated Build Started - ROCKY9 |
|
✅ Automated Build Completed Successfully - ROCKY9
📂 Results Location (S3DF): $AD_BUILD_SCRATCH/adbuild/BuildSystem/main/ROCKY9/69b9dd26e1677654d72d6ae9 |
2 participants
Summary
PUT /container/deploymentendpoint for deploying containerized apps via Docker ComposeContainerDictPydantic model to validate deployment payloads from core-build-systemCONTAINER_{APP_KEY}_{SECRET}database_urlis required; redis and GHCR credentials are optional, supporting apps with different infrastructure needsHow it works
deploymentType: "container"PUT /container/deploymenton this controllerCONTAINER_REACT_SQUIRREL_BACKEND_DATABASE_URL)ansible-playbook container_module/container_deploy.ymlfrom build-system-playbooks