Whales - Gaby Webb

[gabythedev]

No description provided.

[kaidamasaki]

Great job!

I noted a couple of small stylistic things but overall everything looks really solid.

Well done!

[kaidamasaki]

Since you immediately return this you don't need to assign it to a variable:

Suggested change

	goal_dict = {
	"id": self.goal_id,
	"title": self.title,
	}
	return goal_dict
	return {
	"id": self.goal_id,
	"title": self.title,
	}

[kaidamasaki]

This can be simplified to:

Suggested change

	task_dict = {
	"id": self.task_id,
	"title": self.title,
	"description": self.description
	}
	if self.completed_at is None:
	task_dict["is_complete"] = False
	else:
	task_dict["is_complete"] = True
	task_dict = {
	"id": self.task_id,
	"title": self.title,
	"description": self.description,
	"is_complete": bool(self.completed_at)
	}

[kaidamasaki]

Style: Since this is a method on the Goal class having goal in the name is redundant:

Suggested change

	def create_goal_dict(self):
	def create_dict(self):

[kaidamasaki]

I like this helper function. It's really clearly named and clean. 😃

(You even have great error messages!)

[kaidamasaki]

Style: Since you don't do anything with this variable it's a best practice not to store it:

Suggested change

	post_message = requests.post(path, data=data, headers=headers)
	requests.post(path, data=data, headers=headers)