This repository was archived by the owner on Dec 23, 2018. It is now read-only.
Update reviews.py search for subreview text#32
Open
kevinlondon wants to merge 1 commit intoadamlwgriffiths:masterfrom
Open
Update reviews.py search for subreview text#32kevinlondon wants to merge 1 commit intoadamlwgriffiths:masterfrom
kevinlondon wants to merge 1 commit intoadamlwgriffiths:masterfrom
Conversation
The hook for the text has changed from an `a` tag to a `span`.
Owner
|
Because of Amazon's flip-flopping between styles, I think it's a good idea to leave the old |
Owner
|
Lol, happy belated birthday |
gardart
reviewed
Feb 5, 2018
gardart
left a comment
gardart
left a comment
There was a problem hiding this comment.
alternative method without using a or span
| @property | ||
| def text(self): | ||
| tag = self.soup.find('a', class_=re.compile('review-text')) | ||
| tag = self.soup.find('span', class_=re.compile('review-text')) |
There was a problem hiding this comment.
what about this method:
tag = self.soup.find(class_=re.compile('review-text'))
Owner
|
If it works for the majority of pages, then sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hook for the text has changed from an
atag to aspan.