Conversation
- Increase expect.timeout 10s → 15s to survive cold Lambda responses
- After startGame, wait for a game button before snapping rather than
assuming the WebSocket response arrived
- Replace waitForTimeout(1_000) after fold with a proper wait for
deal/peek on the folder's screen
- Use Promise.any to wait for fold to appear on either player's page
before checking who is active
- Drop the remaining explicit { timeout: 10_000 } overrides so the
global timeout applies consistently
- Add .first() to .or() locators where multiple buttons are visible
simultaneously (deal + peek coexist on the between-hands screen)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the e2e tests so they'll work against the live deployed versions of the service.