Degrade gracefully on malformed URLs in _parse#141
Merged
Conversation
urlsplit raises ValueError on some malformed inputs (e.g. a bad IPv6 literal like HTTP://[::1]&). This leaked out of get_base_url and get_hostinfo, which are contracted to return a value for any string. Guard _parse so those inputs degrade to empty parts, matching how a hostless URL already parses. get_host_and_path still raises its own documented incomplete-URL error.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 857 860 +3
Branches 167 167
=========================================
+ Hits 857 860 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_base_url()/get_hostinfo() and other helpers that route through the shared _parse() choke point leak a raw ValueError on malformed URLs like
HTTP://[::1]&("Invalid IPv6 URL" from urlsplit). These helpers already degrade to empty output for hostless input, so a caller iterating over a list of scraped URLs hits an uncaught crash on one bad entry instead of the same graceful skip.Wrap the urlsplit call in _parse in a try/except ValueError that returns an empty SplitResult, so malformed URLs degrade like hostless ones. Added a regression test asserting the specific malformed inputs return empty host info rather than raising.
Repro: