fix: do not treat empty href quotes as URLs#143
Open
santhreal wants to merge 1 commit into
Open
Conversation
LINK_REGEX required at least one href character, so href='' captured the closing quote and extract_links emitted paths like /%27. Allow empty matches so empty hrefs resolve to the page URL like other relatives.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 14 14
Lines 905 905
Branches 173 173
=======================================
Hits 903 903
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_linksturns an empty single-quoted href into a fake path.LINK_REGEXrequired at least one character inside the quotes, so forhref=''it captured the closing quote andcheck_urlnormalized that to/%27.Empty hrefs should resolve like other relative links (to the page URL). Allow an empty match in
LINK_REGEX.