Accept trailing-dot FQDN hosts in domain_filter#145
Open
santhreal wants to merge 2 commits into
Open
Conversation
extract_domain already strips a single trailing DNS dot, but check_url rejected the same hosts via domain_filter, dropping valid crawl URLs.
extract_domain already strips a single trailing DNS dot, but check_url rejected the same hosts via domain_filter, dropping valid crawl URLs. Reuse and extend _strip_trailing_dot for host and host:port forms.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
=======================================
Coverage 99.77% 99.78%
=======================================
Files 14 14
Lines 905 912 +7
Branches 173 175 +2
=======================================
+ Hits 903 910 +7
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_url("http://example.com./page")returnedNonebecausedomain_filterrejected trailing-dot FQDN netlocs, whileextract_domainalready strips that form and returnsexample.com.Reuse and extend
_strip_trailing_dotfor host and host:port forms before validation.