Skip to content

Pass host without userinfo to domain_filter in check_url#146

Open
santhreal wants to merge 1 commit into
adbar:masterfrom
santhreal:fix/domain-filter-userinfo-netloc
Open

Pass host without userinfo to domain_filter in check_url#146
santhreal wants to merge 1 commit into
adbar:masterfrom
santhreal:fix/domain-filter-userinfo-netloc

Conversation

@santhreal

Copy link
Copy Markdown
Contributor

check_url passed the full netloc (including userinfo) to domain_filter, so valid URLs like http://user@t.co/ were rejected even though is_valid_url accepted them.

Strip userinfo before the domain check.

Userinfo in netloc made valid URLs like http://user@t.co/ fail the domain check.
@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.77%. Comparing base (6f0f507) to head (1deff11).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          14       14           
  Lines         905      906    +1     
  Branches      173      173           
=======================================
+ Hits          903      904    +1     
  Misses          2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant