Skip to content

fix: correct build command for Go #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 1 commit into from
Feb 10, 2026
Merged

fix: correct build command for Go #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions adbc_drivers_dev/make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ def maybe_build_docker(
env: dict[str, str],
args: list[str],
ci: bool,
container: str,
) -> None:
if not ci or platform.system() != "Linux" or to_bool(get_var("DEBUG", "False")):
check_call(args, cwd=driver_root, env=env)
Expand Down Expand Up @@ -257,11 +258,11 @@ def maybe_build_docker(

command.extend(
[
"manylinux-rust",
container,
"--",
"bash",
"-c",
f"cd /source/{driver_root.relative_to(repo_root)} && env {smuggle_env} {' '.join(args)}",
f"cd /source/{driver_root.relative_to(repo_root)} && env {smuggle_env} {' '.join(shlex.quote(arg) for arg in args)}",
]
)
check_call(command, cwd=Path(__file__).parent, env=env)
Expand Down Expand Up @@ -313,7 +314,7 @@ def build_go(
append_flags(env, "CGO_CFLAGS", "-mmacosx-version-min=11.0")
append_flags(env, "CGO_LDFLAGS", "-mmacosx-version-min=11.0")

if ci and platform.system() == "Linux":
if ci and platform.system() == "Linux" and not to_bool(get_var("DEBUG", "False")):
check_call(["go", "mod", "vendor"], cwd=driver_root)
ldflags += (
" -linkmode external -extldflags=-Wl,--version-script=/only-export-adbc.ld"
Expand All @@ -336,6 +337,7 @@ def build_go(
"./pkg",
],
ci=ci,
container="manylinux",
)
else:
check_call(
Expand Down Expand Up @@ -404,6 +406,7 @@ def build_rust(
env=env,
args=["cargo", "build", *args],
ci=ci,
container="manylinux-rust",
)

lib = driver_root / "target"
Expand Down Expand Up @@ -481,7 +484,7 @@ def check_linux(binary: Path) -> None:
]
).splitlines()

# TODO(https://github.com/adbc-drivers/dev/issues/36): check exported symbols
# Make sure only 'Adbc*' symbols are exported
bad_symbols = []
for symbol in symbols:
if " T " not in symbol:
Expand Down