-
Notifications
You must be signed in to change notification settings - Fork 1
perf: Optimize Atkinson dithering loop with flattened buffer and direct Pix access #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ct Pix access - Replace `[][]int` with flattened `[]int` to reduce allocations and improve cache locality. - Use direct `Pix` access instead of `GrayAt` interface method. - Fix bug where non-zero origin images were processed incorrectly. - Add regression test `TestAtkinsonNonZeroOrigin`. Co-authored-by: adcondev <38170282+adcondev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
👋 Thanks for opening this PR, @adcondev! Here's what will happen next:
Please make sure:
|
⚡ Benchmark Results📈 Performance Comparison📊 Click to expand detailed resultsCurrent Branch ResultsBase Branch Results💡 Note: Use 🎯 Summary
|
|
not happening |
💡 What: Replaced the
[][]intworking buffer with a flattened[]intslice and switched fromgray.GrayAt(x, y)to directgray.Pixaccess in theapplyAtkinsonfunction.🎯 Why: To improve performance by reducing memory allocations (from
height+1to1), improving cache locality, and eliminating interface method overhead. This also fixes a bug whereGrayAtwas called with absolute coordinates (0,0) even if the input image was a subimage with a non-zero origin, which would result in out-of-bounds reads or incorrect pixel data.📊 Measured Improvement:
PR created automatically by Jules for task 14799940096674774583 started by @adcondev