perf(graphics): optimize Atkinson dithering with 1D slice and add test

[adcondev]

💡 What:

• Replaced 2D [][]int slice allocation with a flattened 1D []int slice in applyAtkinson dithering algorithm.
• Updated pixel access logic to use y * width + x indexing.
• Added TestPipeline_Process_Atkinson_DiffusionLogic to verify the modified algorithm correctly diffuses error to all neighbors.

🎯 Why:

• The previous 2D slice allocation caused height + 1 allocations (513 for a 512px height image) and poor cache locality.
• Flattening the slice reduces this to a single allocation and improves memory access patterns.
• The new test ensures that the complex indexing logic required for the flattened slice does not introduce regressions in the dithering pattern.

📊 Measured Improvement:
Benchmark results for a 512x512 image:

Baseline:

• Time: ~6.5 ms/op
• Memory: ~2.14 MB/op
• Allocations: 515 allocs/op

Optimized:

• Time: ~5.8 ms/op (~12% faster)
• Memory: ~2.13 MB/op
• Allocations: 3 allocs/op (~99.4% reduction)

The massive reduction in allocations significantly reduces GC pressure for high-throughput printing scenarios.

---

PR created automatically by Jules for task 7699484235556877511 started by @adcondev

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[github-actions]

👋 Thanks for opening this PR, @adcondev!

Here's what will happen next:

• 🤖 Automated checks will run
• 🏷️ Labels will be added automatically
• 👀 A maintainer will review your changes

Please make sure:

• ✅ All tests pass
• 📝 The PR title follows conventional commits
• 📋 The PR template is filled out completely

[github-actions]

⚡ Benchmark Results

📈 Performance Comparison

📊 Click to expand detailed results

Current Branch Results

BenchmarkNewDocument-4    	1000000000	         0.3124 ns/op	       0 B/op	       0 allocs/op
BenchmarkBuildSimple-4    	 3682188	       325.6 ns/op	     240 B/op	       4 allocs/op
BenchmarkBuildComplex-4   	  421665	      2791 ns/op	    1809 B/op	      25 allocs/op
BenchmarkToJSON-4         	  544831	      2078 ns/op	     592 B/op	       3 allocs/op
BenchmarkParseDocument_Minimal-4    	  511748	      2323 ns/op	     568 B/op	      14 allocs/op
BenchmarkParseDocument_Receipt-4    	   92856	     12622 ns/op	    2392 B/op	      34 allocs/op
BenchmarkCommandUnmarshal_Text-4    	  418406	      2722 ns/op	     568 B/op	      19 allocs/op
BenchmarkCommandUnmarshal_Table-4   	  273000	      4188 ns/op	     944 B/op	      21 allocs/op
BenchmarkTextCommandParsing-4       	  528409	      2124 ns/op	     544 B/op	      16 allocs/op
BenchmarkTableCommandParsing-4      	  242301	      4804 ns/op	    1000 B/op	      29 allocs/op
BenchmarkParseHexString-4           	 8725134	       138.6 ns/op	      48 B/op	       2 allocs/op
BenchmarkCleanHexString-4           	 6328599	       188.8 ns/op	      64 B/op	       2 allocs/op
BenchmarkContainsSequence-4         	367970827	         3.243 ns/op	       0 B/op	       0 allocs/op
BenchmarkCheckCriticalCommands-4    	36181383	        39.25 ns/op	       0 B/op	       0 allocs/op
BenchmarkDocument_Validate-4       	14582882	        82.85 ns/op	       0 B/op	       0 allocs/op
BenchmarkParseDocument_Simple-4    	  496352	      2394 ns/op	     568 B/op	      14 allocs/op
BenchmarkParseDocument_Complex-4   	  139951	      8506 ns/op	    1352 B/op	      26 allocs/op
BenchmarkPrintImage_Small-4             	     608	   1985778 ns/op	 3469936 B/op	      24 allocs/op
BenchmarkPrintImage_Medium-4            	     301	   3670068 ns/op	 5481088 B/op	      24 allocs/op
BenchmarkPrintImage_ThermalPreview-4    	     135	   8651296 ns/op	 5231184 B/op	  230423 allocs/op

Base Branch Results

BenchmarkNewDocument-4    	1000000000	         0.3121 ns/op	       0 B/op	       0 allocs/op
BenchmarkBuildSimple-4    	 3632516	       332.6 ns/op	     240 B/op	       4 allocs/op
BenchmarkBuildComplex-4   	  425894	      2762 ns/op	    1809 B/op	      25 allocs/op
BenchmarkToJSON-4         	  536082	      2075 ns/op	     592 B/op	       3 allocs/op
BenchmarkParseDocument_Minimal-4    	  497775	      2308 ns/op	     568 B/op	      14 allocs/op
BenchmarkParseDocument_Receipt-4    	   93919	     12889 ns/op	    2392 B/op	      34 allocs/op
BenchmarkCommandUnmarshal_Text-4    	  422502	      2699 ns/op	     568 B/op	      19 allocs/op
BenchmarkCommandUnmarshal_Table-4   	  276949	      4185 ns/op	     944 B/op	      21 allocs/op
BenchmarkTextCommandParsing-4       	  524671	      2109 ns/op	     544 B/op	      16 allocs/op
BenchmarkTableCommandParsing-4      	  239756	      4783 ns/op	    1000 B/op	      29 allocs/op
BenchmarkParseHexString-4           	 8633983	       136.6 ns/op	      48 B/op	       2 allocs/op
BenchmarkCleanHexString-4           	 6666956	       179.3 ns/op	      64 B/op	       2 allocs/op
BenchmarkContainsSequence-4         	370109503	         3.216 ns/op	       0 B/op	       0 allocs/op
BenchmarkCheckCriticalCommands-4    	31390849	        35.91 ns/op	       0 B/op	       0 allocs/op
BenchmarkDocument_Validate-4       	14525600	        83.86 ns/op	       0 B/op	       0 allocs/op
BenchmarkParseDocument_Simple-4    	  494805	      2394 ns/op	     568 B/op	      14 allocs/op
BenchmarkParseDocument_Complex-4   	  138333	      8527 ns/op	    1352 B/op	      26 allocs/op
BenchmarkPrintImage_Small-4             	     598	   1974530 ns/op	 3469944 B/op	      24 allocs/op
BenchmarkPrintImage_Medium-4            	     331	   3689010 ns/op	 5481089 B/op	      24 allocs/op
BenchmarkPrintImage_ThermalPreview-4    	     139	   8600284 ns/op	 5235277 B/op	  230723 allocs/op

💡 Note: Use benchstat for statistical comparison

🎯 Summary

• Total Benchmarks: 32
• Average Speed: 2595642 ns/op
• Average Memory: 2396764 B/op
• Average Allocations: 41077 allocs/op

[Copilot]

Pull request overview

This PR optimizes the Atkinson dithering algorithm by replacing 2D slice allocation with a flattened 1D slice, significantly improving performance and reducing garbage collection pressure for high-throughput printing scenarios.

Changes:

• Replaced 2D [][]int slice with flattened 1D []int slice in applyAtkinson dithering algorithm
• Updated all pixel access logic to use flat indexing (y * width + x)
• Added comprehensive test to verify error diffusion to all 6 neighbors works correctly with the new indexing

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pkg/graphics/graph_engine.go	Optimized Atkinson dithering by replacing 2D slice allocation with 1D flattened slice and updating all neighbor access patterns to use calculated offsets
pkg/graphics/graph_engine_test.go	Added test that verifies error diffusion logic works correctly for all 6 Atkinson neighbors (x+1, x+2, y+1/x-1, y+1/x, y+1/x+1, y+2/x)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.