Skip to content

Conversation

@adcondev
Copy link
Owner

Replaced manual little-endian conversion logic with shared.ToLittleEndian in pkg/commands/bitimage package to improve code health and consistency. Confirmed functionality with existing tests.


PR created automatically by Jules for task 8170664250265593066 started by @adcondev

Replace manual bitwise operations for little-endian conversion with the `shared.ToLittleEndian` helper function in `download_graphics_commands.go`, `graphics_commands.go`, and `nv_graphics_commands.go`. This improves code readability and maintainability by standardizing on the shared utility.

Affected functions:
- `DefineDownloadGraphics`
- `DefineDownloadGraphicsColumn`
- `StoreRasterGraphicsInBuffer`
- `StoreColumnGraphicsInBuffer`
- `DefineNVRasterGraphics`
- `DefineNVColumnGraphics`

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

👋 Thanks for opening this PR, @adcondev!

Here's what will happen next:

  • 🤖 Automated checks will run
  • 🏷️ Labels will be added automatically
  • 👀 A maintainer will review your changes

Please make sure:

  • ✅ All tests pass
  • 📝 The PR title follows conventional commits
  • 📋 The PR template is filled out completely

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

⚡ Benchmark Results

📈 Performance Comparison

📊 Click to expand detailed results

Current Branch Results

BenchmarkNewDocument-4    	1000000000	         0.3118 ns/op	       0 B/op	       0 allocs/op
BenchmarkBuildSimple-4    	 3744178	       336.1 ns/op	     240 B/op	       4 allocs/op
BenchmarkBuildComplex-4   	  423075	      2706 ns/op	    1809 B/op	      25 allocs/op
BenchmarkToJSON-4         	  514357	      2077 ns/op	     592 B/op	       3 allocs/op
BenchmarkParseDocument_Minimal-4    	  502530	      2309 ns/op	     568 B/op	      14 allocs/op
BenchmarkParseDocument_Receipt-4    	   93655	     12777 ns/op	    2392 B/op	      34 allocs/op
BenchmarkCommandUnmarshal_Text-4    	  427345	      2702 ns/op	     568 B/op	      19 allocs/op
BenchmarkCommandUnmarshal_Table-4   	  276130	      4189 ns/op	     944 B/op	      21 allocs/op
BenchmarkTextCommandParsing-4       	  540770	      2117 ns/op	     544 B/op	      16 allocs/op
BenchmarkTableCommandParsing-4      	  242691	      4779 ns/op	    1000 B/op	      29 allocs/op
BenchmarkParseHexString-4           	 7744710	       154.4 ns/op	      48 B/op	       2 allocs/op
BenchmarkCleanHexString-4           	 6458258	       184.6 ns/op	      64 B/op	       2 allocs/op
BenchmarkContainsSequence-4         	295838120	         4.057 ns/op	       0 B/op	       0 allocs/op
BenchmarkCheckCriticalCommands-4    	33744504	        37.17 ns/op	       0 B/op	       0 allocs/op
BenchmarkDocument_Validate-4       	14450967	        82.51 ns/op	       0 B/op	       0 allocs/op
BenchmarkParseDocument_Simple-4    	  498792	      2395 ns/op	     568 B/op	      14 allocs/op
BenchmarkParseDocument_Complex-4   	  138625	      8599 ns/op	    1352 B/op	      26 allocs/op
BenchmarkPrintImage_Small-4             	     619	   1977325 ns/op	 3469946 B/op	      24 allocs/op
BenchmarkPrintImage_Medium-4            	     312	   3691335 ns/op	 5481087 B/op	      24 allocs/op
BenchmarkPrintImage_ThermalPreview-4    	     138	   8544656 ns/op	 5231176 B/op	  230423 allocs/op

Base Branch Results

BenchmarkNewDocument-4    	1000000000	         0.3118 ns/op	       0 B/op	       0 allocs/op
BenchmarkBuildSimple-4    	 3668593	       327.3 ns/op	     240 B/op	       4 allocs/op
BenchmarkBuildComplex-4   	  437653	      2697 ns/op	    1809 B/op	      25 allocs/op
BenchmarkToJSON-4         	  535678	      2065 ns/op	     592 B/op	       3 allocs/op
BenchmarkParseDocument_Minimal-4    	  504972	      2322 ns/op	     568 B/op	      14 allocs/op
BenchmarkParseDocument_Receipt-4    	   94044	     12603 ns/op	    2392 B/op	      34 allocs/op
BenchmarkCommandUnmarshal_Text-4    	  430147	      2686 ns/op	     568 B/op	      19 allocs/op
BenchmarkCommandUnmarshal_Table-4   	  253207	      4133 ns/op	     944 B/op	      21 allocs/op
BenchmarkTextCommandParsing-4       	  521871	      2144 ns/op	     544 B/op	      16 allocs/op
BenchmarkTableCommandParsing-4      	  245856	      4734 ns/op	    1000 B/op	      29 allocs/op
BenchmarkParseHexString-4           	 7675179	       154.1 ns/op	      48 B/op	       2 allocs/op
BenchmarkCleanHexString-4           	 6522556	       183.1 ns/op	      64 B/op	       2 allocs/op
BenchmarkContainsSequence-4         	296191497	         4.053 ns/op	       0 B/op	       0 allocs/op
BenchmarkCheckCriticalCommands-4    	33551913	        37.12 ns/op	       0 B/op	       0 allocs/op
BenchmarkDocument_Validate-4       	14473544	        82.78 ns/op	       0 B/op	       0 allocs/op
BenchmarkParseDocument_Simple-4    	  498157	      2383 ns/op	     568 B/op	      14 allocs/op
BenchmarkParseDocument_Complex-4   	  139285	      8533 ns/op	    1352 B/op	      26 allocs/op
BenchmarkPrintImage_Small-4             	     598	   1954614 ns/op	 3469937 B/op	      24 allocs/op
BenchmarkPrintImage_Medium-4            	     324	   3625676 ns/op	 5481090 B/op	      24 allocs/op
BenchmarkPrintImage_ThermalPreview-4    	     140	   8715682 ns/op	 5231178 B/op	  230423 allocs/op

💡 Note: Use benchstat for statistical comparison

🎯 Summary

  • Total Benchmarks: 32
  • Average Speed: 2612487 ns/op
  • Average Memory: 2396764 B/op
  • Average Allocations: 41077 allocs/op

@adcondev adcondev marked this pull request as ready for review February 12, 2026 21:13
Copilot AI review requested due to automatic review settings February 12, 2026 21:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adcondev adcondev moved this to In review in POS RED2000 Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

1 participant